Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): support env where requestAnimationFrame is not available #26779

Closed
wants to merge 2 commits into from

Conversation

marclaval
Copy link
Contributor

I faced this issue when running the router tests with Ivy.

@mary-poppins
Copy link

You can preview 4b5c140 at https://pr26779-4b5c140.ngbuilds.io/.

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Oct 26, 2018
@ngbot ngbot bot added this to the needsTriage milestone Oct 26, 2018
@mary-poppins
Copy link

You can preview ba1aaa8 at https://pr26779-ba1aaa8.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f27f5c5 at https://pr26779-f27f5c5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview df3014f at https://pr26779-df3014f.ngbuilds.io/.

Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with changes 99d2764 Please verify that you are OK with it.

@mhevery mhevery closed this Oct 26, 2018
@mhevery mhevery reopened this Oct 26, 2018
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 26, 2018
@ngbot
Copy link

ngbot bot commented Oct 26, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_docs_examples_0" is failing
    pending status "google3" is pending
    pending status "code-review/pullapprove" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@mary-poppins
Copy link

You can preview 99d2764 at https://pr26779-99d2764.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a41f609 at https://pr26779-a41f609.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c1d5ff8 at https://pr26779-c1d5ff8.ngbuilds.io/.

@googlebot
Copy link

CLAs look good, thanks!

@mary-poppins
Copy link

You can preview 277c0ea at https://pr26779-277c0ea.ngbuilds.io/.

@kara
Copy link
Contributor

kara commented Nov 1, 2018

@marclaval Can you rebase this?

@kara kara removed the action: merge The PR is ready for merge by the caretaker label Nov 1, 2018
@mary-poppins
Copy link

You can preview e27d428 at https://pr26779-e27d428.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a529f89 at https://pr26779-a529f89.ngbuilds.io/.

@marclaval
Copy link
Contributor Author

@kara rebase done, PTAL

@kara kara added the action: merge The PR is ready for merge by the caretaker label Nov 5, 2018
@kara
Copy link
Contributor

kara commented Nov 5, 2018

presubmit

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Nov 5, 2018
@kara
Copy link
Contributor

kara commented Nov 5, 2018

@marclaval @mhevery Presubmit failed because Closure doesn't like the usage of this in util.ts

(failure)

@mary-poppins
Copy link

You can preview 8be2c06 at https://pr26779-8be2c06.ngbuilds.io/.

@marclaval marclaval force-pushed the fixScheduler branch 3 times, most recently from 8479041 to 4bb4ded Compare November 6, 2018 10:25
@mary-poppins
Copy link

You can preview 4bb4ded at https://pr26779-4bb4ded.ngbuilds.io/.

@marclaval
Copy link
Contributor Author

@kara @mhevery I've updated the PR to use global from the main util.ts, I guess it should be fine now.

@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 6, 2018
@kara kara closed this in 297c54e Nov 6, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants