-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): support env where requestAnimationFrame is not available #26779
Conversation
You can preview 4b5c140 at https://pr26779-4b5c140.ngbuilds.io/. |
4b5c140
to
ba1aaa8
Compare
You can preview ba1aaa8 at https://pr26779-ba1aaa8.ngbuilds.io/. |
ba1aaa8
to
f27f5c5
Compare
You can preview f27f5c5 at https://pr26779-f27f5c5.ngbuilds.io/. |
f27f5c5
to
df3014f
Compare
You can preview df3014f at https://pr26779-df3014f.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with changes 99d2764 Please verify that you are OK with it.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
You can preview 99d2764 at https://pr26779-99d2764.ngbuilds.io/. |
99d2764
to
a41f609
Compare
You can preview a41f609 at https://pr26779-a41f609.ngbuilds.io/. |
You can preview c1d5ff8 at https://pr26779-c1d5ff8.ngbuilds.io/. |
c1d5ff8
to
4ffeeb9
Compare
CLAs look good, thanks! |
4ffeeb9
to
277c0ea
Compare
You can preview 277c0ea at https://pr26779-277c0ea.ngbuilds.io/. |
@marclaval Can you rebase this? |
277c0ea
to
e27d428
Compare
You can preview e27d428 at https://pr26779-e27d428.ngbuilds.io/. |
e27d428
to
a529f89
Compare
You can preview a529f89 at https://pr26779-a529f89.ngbuilds.io/. |
@kara rebase done, PTAL |
@marclaval @mhevery Presubmit failed because Closure doesn't like the usage of (failure) |
a529f89
to
8be2c06
Compare
You can preview 8be2c06 at https://pr26779-8be2c06.ngbuilds.io/. |
8479041
to
4bb4ded
Compare
You can preview 4bb4ded at https://pr26779-4bb4ded.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I faced this issue when running the router tests with Ivy.